Skip to content

Conversation

@ndimiduk
Copy link
Member

No description provided.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk changed the title HBASE-29787 Move static checks to a Github Action HBASE-29787 Run static checks to a Github Action Dec 19, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk marked this pull request as ready for review December 19, 2025 18:09
@ndimiduk
Copy link
Member Author

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

@Apache9
Copy link
Contributor

Apache9 commented Dec 20, 2025

I think this is working. Please help me out by double-checking that the checks run by the new system have parity with the jenkins build.

Let's just try it on a special branch? Scripts are always hard to review...

@Apache9
Copy link
Contributor

Apache9 commented Dec 20, 2025

Ah, I saw the checks, let me check the result...

@Apache9
Copy link
Contributor

Apache9 commented Dec 20, 2025

Seems we missed lots of checks...

+1 overall
Vote	Subsystem	Runtime	Log	Comment
Prechecks
+1	dupname	0m 0s		No case conflicting files found.
+1	@author	0m 0s		The patch does not contain any @author tags.
master Compile Tests
+1	spotless	0m 53s		branch has no errors when running spotless:check.
Patch Compile Tests
+1	codespell	0m 13s		No new issues.
+1	detsecrets	4m 22s		No new issues.
+1	blanks	0m 0s		The patch has no blanks issues.
+1	yamllint	0m 0s		No new issues.
+1	spotless	0m 35s		patch has no errors when running spotless:check.
Other Tests
+1	asflicense	0m 11s		The patch does not generate ASF License warnings.
6m 27s		
Subsystem	Report/Notes
GITHUB PR	https://github.com/apache/hbase/pull/7566
Optional Tests	dupname asflicense codespell detsecrets yamllint spotless
uname	Linux 5359e6d56b16 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/github/workspace/src/dev-support/hbase-personality.sh
git revision	master / efb501962294022f359c4cba545386ca4c78c7e9
modules	C: . U: .
versions	git=2.34.1 maven=3.9.9 codespell=2.4.1 detsecrets=1.5.0 yamllint=1.35.1
Powered by	Apache Yetus 0.16.0-SNAPSHOT https://yetus.apache.org
This message was automatically generated.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

1 similar comment
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@github-actions

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@github-actions

This comment has been minimized.

@ndimiduk
Copy link
Member Author

FYI @Apache9 @petersomogyi I snuck in HBASE-29829 Pagination support for Hide Old Comments in PRs because the issue became visible here.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Peter Somogyi <petersomogyi@apache.org>
@Apache-HBase

This comment has been minimized.

@ndimiduk ndimiduk force-pushed the 29787-gh-actions-static branch from dea7d1a to 3bc9df6 Compare January 15, 2026 09:36
@github-actions
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/50// in case of problems.

@github-actions
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 yamllint 0m 0s yamllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 spotless 0m 49s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 spotless 0m 36s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
3m 12s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://nightlies.apache.org/hbase/HBase-PreCommit-GH-Actions-PR/PR-7566/50/yetus-general-check/output/Dockerfile
GITHUB PR #7566
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint
uname Linux 5d804605ff95 6.11.0-1018-azure #18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3bc9df6
Max. process+thread count 43 (vs. ulimit of 30000)
modules C: . U: .
versions git=2.34.1 maven=3.9.8 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/31/console in case of problems.

1 similar comment
@Apache-HBase
Copy link

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/31/console in case of problems.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 21s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/31/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7566
Optional Tests
uname Linux 0fa0d364502d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3bc9df6
Max. process+thread count 35 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/31/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 yamllint 0m 0s yamllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 1s No new issues.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
3m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/31/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7566
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless yamllint
uname Linux 546beb872377 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3bc9df6
Max. process+thread count 45 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7566/31/console
versions git=2.34.1 maven=3.9.8 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 3e70070 into master Jan 15, 2026
3 checks passed
@ndimiduk ndimiduk deleted the 29787-gh-actions-static branch January 15, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants